nus-pe-bot
commented
1 year ago [IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]
Team's Response
Originally, we wanted to start by creating features that we thought would best help NUS students with a minimalistic design and ensure data consistency through only a few types of fields. However, we will consider adding this feature to future iterations of the application.
https://ay2223s2-cs2113-t15-2.github.io/tp/UserGuide.html#add-new-secret
Items for the Tester to Verify
:question: Issue response
Team chose [response.NotInScope]
- [ ] I disagree
Reason for disagreement: [replace this with your reason]
The "new" command forces the user to either create a basic password, credit card number, crypto wallet, NUSNet ID, NUS Student ID, or Wifi Password as a secret. It also enforces that each of these types of secret follows the usual format for this type of data (e.g. A1234567B for NUS Student ID).
However, there are many other types of data that someone might want to store as a secret (for example a passport number, student ID from another school, etc.).
Although it is unreasonable for there to be a different option for each of the infinite possible types of data, this problem could easily be solved by adding a "basic secret" secret option which just consists of a "description" field and a "data" field and would enable the user to store many more different types of data.