search

superlinear-ai / poetry-cookiecutter

🍪 Poetry Cookiecutter is a modern Cookiecutter template for scaffolding Python packages and apps
GNU Affero General Public License v3.0
252 stars 37 forks source link

fix: let Dev Containers manage Docker mounts #170

Closed lsorber closed 1 year ago

lsorber commented 1 year ago

This removes the bind mount from the devcontainer Docker Compose service so that the Dev Containers CLI can manage the mounts as it wants to.

Previously, starting a Dev Container by cloning a repo into a (named) Docker volume would lead to a crash. After this PR, this will work as intended. Which also means that the Open in Dev Containers badge actually works!

RubenPants commented 1 year ago

@lsorber the pipeline seems to fail?

lsorber commented 1 year ago

@lsorber the pipeline seems to fail?

Will fix!

lsorber commented 1 year ago

Superseded by #176.