superlinear-ai / poetry-cookiecutter

🍪 Poetry Cookiecutter is a modern Cookiecutter template for scaffolding Python packages and apps
GNU Affero General Public License v3.0
252 stars 37 forks source link

Add gitlab workflow and gitlens to vscode extensions #200

Closed Ale-Cas closed 7 months ago

Ale-Cas commented 1 year ago

Add Gitlab and Gitlens to the vscode extensions installed in the devcontainer.

lsorber commented 1 year ago

Hi Alessio, thank you for the contribution! This project gives the user the choice between GitHub Actions and GitLab CI/CI, so I would like to make this extension conditional on the latter option. Would you like me to make that change, or do you prefer to do it?

Ale-Cas commented 1 year ago

HI 👍 No problem, I can do it. You mean only for the gitlab workflow extension right?

lsorber commented 1 year ago

Yes indeed, but also I'd rather not add the GitLens extension in this template (which we're trying to keep as minimal as we can).

lsorber commented 7 months ago

Closing because this PR will be superseded by https://github.com/radix-ai/poetry-cookiecutter/pull/223.