search

superlistapp / super_editor

A Flutter toolkit for building document editors and readers
https://superlist.com/SuperEditor/
MIT License
1.69k stars 249 forks source link

[SuperEditor][SuperReader] - Don't linkify values with multiple periods #1759

Open matthew-carroll opened 11 months ago

matthew-carroll commented 11 months ago

I discovered that linkification in SuperEditor currently linkifies text with multiple periods, e.g., something....abc converts to a link.

Check for any other related error patterns, fix those patterns, and add tests to ensure those error patterns don't linkify.

rutvik110 commented 10 months ago

This seems to be an issue arising from the linkify package url parsers which is identifying such patterns a valid url. I've filed issue for this here.

Do we intend to handle this on our side? or want to wait till this is fixed within the package? I'll file up a PR on the package with a fix but based on the activity on the package, it may take some time to have the fix merged in there.

matthew-carroll commented 10 months ago

We can wait for the linkify package to fix it, if that's something that's going to happen.