search

superlistapp / super_editor

A Flutter toolkit for building document editors and readers
https://superlist.com/SuperEditor/
MIT License
1.59k stars 233 forks source link

[SuperEditor] [iOS] Vertical scrolling occurring during horizontal drag gestures #2081

Open jakeett opened 1 month ago

jakeett commented 1 month ago

Package Version stable branch

In iOS apps, views containing a Super Editor can be scrolled vertically even when dragging horizontally. Once a horizontal drag gesture is initiated, only movement along the x-axis is consumed, and y-axis movements are ignored until a new drag gesture is started.

https://github.com/superlistapp/super_editor/assets/172330941/e45f555f-91a5-4d36-98bf-8bafbd40a163

matthew-carroll commented 1 month ago

@jakeett what's the expected behavior here? Are you saying that when you start dragging horizontally, the editor shouldn't ever move vertically no matter how far up/down you move your finger?

If so, can you please include a video of some other iOS app with a document that behaves the way you describe?

jakeett commented 4 weeks ago

No sorry, I am saying that horizontal drag gestures should not be mapped to vertical scroll movements. In the video I was trying to demonstrate that when you scroll left/right, then the screen is getting scrolled vertically. Also, when the user initiates a horizontal drag gesture, then all vertical movement is getting ignored.

I have taken some videos with clicks highlighted, hopefully that makes it a bit clearer to see.

Current behaviour Expected behaviour

Also this doesn't happen on android