superlistapp / super_sliver_list

Drop-in replacement for SliverList and ListView that can handle large amount of items with variable extents and reliably jump / animate to any item.
https://superlistapp.github.io/super_sliver_list/
MIT License
277 stars 15 forks source link

Docs borrowed from ListView hide the interesting parts #21

Closed gnprice closed 6 months ago

gnprice commented 6 months ago

This library is very interesting! I'm beginning to read the code to understand what it's doing.

May I gently suggest not copy-pasting the documentation from upstream's ListView and related classes? This is seen currently at today's prerelease version: https://pub.dev/documentation/super_sliver_list/0.2.0-dev.2/super_sliver_list/SuperListView-class.html and in main.

This causes two problems:

Instead, the strategy I'd recommend is:

knopp commented 6 months ago

Hey, thank you for the feedback. Indeed entire SuperListView class is basically a carbon copy of ListView, as the class itself doesn't do much else than instantiate the sliver list, which is where the interesting part is.

Now the ListView documentation mostly addresses how to use the ListView, it says very little about the underlying implementation. So I thought maybe it's a good idea to preserve the documentation, but to be honest I find much of Flutter code documentation overly verbose and that is the case here as well.

Your points are good.

knopp commented 6 months ago

I've removed the copied documentation replaced it by references. Admittedly there is still room for improvement.

gnprice commented 6 months ago

Looks great, thanks!