search

superlou / fountain-atom

Grammar and tools for the Fountain screenwriting syntax
MIT License
48 stars 15 forks source link

scene numbers not exported to PDF #80

Closed brunovianna closed 6 years ago

brunovianna commented 6 years ago

Even with the drop-down "scene numbers" set to "both" in the settings, I get no scene numbers in the pdf.

I also tried to manually add scene numbers (using #1# in the scene header, as described in the syntax - https://fountain.io/syntax), but nothing shows up on the pdf.

In any case, congrats and thanks for the great package!

jrbostic commented 6 years ago

@superlou it sounds like there's a confirmed issue with pdf generation using our settings. Idk if it's a new development or some existing edge case. I haven't been able to reproduce it yet though. I just moved and need to get my stuff set up again... Let me know if you have any ideas. I'll look into it asap.

superlou commented 6 years ago

I wonder if it is something Windows specific? I wasn't able to reproduce it on Linux Mint. I'll see if I can try it out on a Windows machine later this week.

brunovianna commented 6 years ago

Actually I use mint too! uname -a: Linux toque 4.15.0-29-generic #31~16.04.1-Ubuntu SMP Wed Jul 18 08:54:04 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

atom 1.30.0 fountain 0.8.0

superlou commented 6 years ago

I've got the same symptoms now. I think the tell-tale is that the contents of configs/afterwritingConfig.json become {} after generating a PDF. I have a vague memory that a recent version of Atom may have changed packages' ability modify their packagePath. However, I can't find a reference to that and might be completely off base there.

superlou commented 6 years ago

packagePath modification is a red herring. There is a problem with:

https://github.com/superlou/fountain-atom/blob/3480f98d111a9c6bf2560fd2db7c9568935923ab/lib/fountain-pdf-config-generator.coffee#L12-L13

configs looks fine, but the output of flatten is always [].

superlou commented 6 years ago

@jrbostic It looks like you are trying to "flatten" an object containing nested objects into a flatter object. Is that something underscore's flatten function does? I thought it was more for arrays.

jrbostic commented 6 years ago

@superlou I have no idea. Doesn't make sense at the moment. I need to get my computer set up to take a look. Doesn't make sense that we would suddenly break from a utility function, unless the version was bumped maybe? The only related thing that I remember that changed was we added selectable fonts for export... So, I guess I'll look there first...

superlou commented 6 years ago

I'm going to close this issue as a duplicate of the more general #69.