search

superlou / lapce-python

Python LSP plugin for the Lapce editor
MIT License
22 stars 4 forks source link

Update plugin to allow configuration of path to pylsp #18

Closed ash-sykes closed 7 months ago

ash-sykes commented 7 months ago

I don't know rust so feel free to change this! - shamelessly copy https://github.com/panekj/lapce-typescript to allow configuration of pylsp binary path

ash-sykes commented 7 months ago

Fixes #17

superlou commented 7 months ago

Thanks for the PR! I'll try to look at it after work tonight. It looks like the lapce-rust plugin doesn't nest the serverPath configuration under "volt": https://github.com/lapce/lapce-rust/blob/master/volt.toml. Can you modify the PR to match? I think lapce-rust is the canonical example. Their approach also seems to require less nesting:

https://github.com/lapce/lapce-rust/blob/41a925b73b013042e3ebfcce3c40b936f0ed529d/src/main.rs#L34-L45

ash-sykes commented 7 months ago

Sure - I've updated as requested