search

supermacro / neverthrow

Type-Safe Errors for JS & TypeScript
MIT License
4.03k stars 84 forks source link

Migrated build system to tsup #570

Open mattpocock opened 3 months ago

mattpocock commented 3 months ago

Also contains work in #569, merge that first.

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: d54205028b774a52502ced2b87ac88913d8d6c67

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

mattpocock commented 2 months ago

The main appeal of tsup is that I trust the declaration files it generates. It also generates one per output type by default (which is recommended by Andrew Branch of the TS team) which means the exports map can be simpler.

If you're happy with your current rollup-based setup, that's fine - but it seemed a bit custom and funky so I thought a low-config, well-maintained option would make sense.

supermacro commented 2 months ago

refraining from diving into this PR until convo for https://github.com/supermacro/neverthrow/pull/569 is clarified.