Prettier and eslint improvements (no dependency upgrades yet)

supermacro / neverthrow

Type-Safe Errors for JS & TypeScript

MIT License

4.03k stars 84 forks source link

Prettier and eslint improvements (no dependency upgrades yet) #574

Closed mattpocock closed 2 months ago

mattpocock commented 3 months ago

Make prettier run on the entire repo, not just the source files
Remove prettier from eslint configs
Made the CI check that code is formatted correctly

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: 8b55bb7da266def3d485c0c2de5404a11d23c4fe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

mattpocock commented 2 months ago

@supermacro The CI appears to be failing because a rollup dependency isn't being added. Have you seen this before? Unsure how to fix. The next solution I'd try would be to delete package-lock.json and remake it, but don't want to bloat the PR.

mattpocock commented 2 months ago

Might be something to do with the GH action cache?

mattpocock commented 2 months ago

This PR is getting a bit out of hand. I am having real trouble rebasing every time a new change is merged. I'll create a new PR which adds the ability to run prettier, but doesn't format the whole repo. Once that's merged we can format the repo properly.