prevent passing a specific error type for `.fromThrowable` without providing an error mapping function

supermacro / neverthrow

Type-Safe Errors for JS & TypeScript

MIT License

4.06k stars 85 forks source link

As discussed in https://github.com/supermacro/neverthrow/pull/567#discussion_r1754313850, the current type signature of fromThrowable allows users to pass a specific error value type, without providing an error mapping function that produces the provided error type:

const safeParse = Result.fromThrowable<typeof JSON.parse, number>(JSON.parse);
      // ^ (text: string, reviver?: (this: any, key: string, value: any) => any) => Result<any, number>

This PR tries to solve that by adding some overloads to the function, only allowing users to specify the error type when a matching error mapping function is provided.

supermacro / neverthrow

prevent passing a specific error type for `.fromThrowable` without providing an error mapping function #583

🦋 Changeset detected