search

supermacro / neverthrow

Type-Safe Errors for JS & TypeScript
MIT License
4.06k stars 85 forks source link

safeTry should not require .safeUnwrap() #589

Closed dmmulroy closed 1 month ago

dmmulroy commented 1 month ago

Resolves #580

edit: Had to bump jest versions for support in using toBeEqual() on classes/objects w/ [Symbol.itereator]() and [Symbol.asyncIterator]()

CC: @mattpocock @m-shaka @supermacro

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: da80693eb90e864688a0e119269fb64128850fc3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ---------- | ----- | | neverthrow | Minor |

Not sure what this means? Click here to learn what changesets are.

[Click here if you're a maintainer who wants to add another changeset to this PR](https://github.com/dmmulroy/neverthrow/new/dmmulroy/symbol-iterator?filename=.changeset/giant-singers-tie.md&value=---%0A%22neverthrow%22%3A%20patch%0A---%0A%0AsafeTry%20should%20not%20require%20.safeUnwrap()%0A)

dmmulroy commented 1 month ago

LGTM, but CI failed again 😢

@m-shaka I missed a , in the eslint-ignore 😭 - fixed and pushed though haha