search

supermarin / ObjectiveSugar

ObjectiveC additions for humans. Ruby style.
MIT License
2.17k stars 190 forks source link

Reduce #81

Closed supermarin closed 10 years ago

supermarin commented 10 years ago

@robinsenior here's your PR #75 merged and counterparts added.

On the side note - By this point I'm thinking if we should stop supporting NSSet additions for 2.0, because the behavior with nils and ordering makes it a bit of mess.

robinsenior commented 10 years ago

@supermarin looks like the Iterators_Modifications_reduceReturnsAResultOfAllTheElements test failed.

supermarin commented 10 years ago

Right - if you take a look in the side note, it's related to the ordering in NSSets. Let's see if I can rewrite the test a bit differently to be order-agnostic

robinsenior commented 10 years ago

Gotcha; want me to wait for the new test to pass before accepting the pull request?

supermarin commented 10 years ago

if it looks okay to you i'll merge it as soon as i push the new test

robinsenior commented 10 years ago

looks good to me

supermarin commented 10 years ago

@robinsenior merged :beers: