search

supermaven-inc / supermaven-nvim

The official Neovim plugin for Supermaven
https://supermaven.com/
MIT License
305 stars 16 forks source link

String slice too long [on util.lua:164] #17

Closed mariesco closed 1 month ago

mariesco commented 1 month ago

I get the following error randomly on my project

Captura de pantalla 2024-05-13 a la(s) 7 28 25 p  m
sm-victorw commented 1 month ago

This was a bug that I believe was fixed in #7, can you update the plugin and see if this happens again?

mariesco commented 1 month ago

This was a bug that I believe was fixed in #7, can you update the plugin and see if this happens again?

I was creating a PR fixing the get_utf8_length function, but I don't have permissions... Now I update and test. What was the problem?

mariesco commented 1 month ago

@victorw-xyz I don't have the problem anymore

I would also like to know how I can get permissions to create PRs and be able to contribute. Thank you so much!

sm-victorw commented 1 month ago

@mariesco The problem was that we were using the str.byte function which did not work for large strings.

You can fork the repository and after committing changes to the fork, make a pull request from the fork. I guess we should include a guide for contributing, so it is more clear.