supermaven-inc / supermaven-nvim

The official Neovim plugin for Supermaven
https://supermaven.com/
MIT License
279 stars 16 forks source link

feature: added nvim-cmp source registration and option to disable built in inline suggestions #28

Closed kaiiserni closed 1 month ago

kaiiserni commented 1 month ago

Description

This pull request adds new nvim-cmp compatibility by registering itself as a source when nvim-cmp is found. This makes the plugin much more usable to me and removes the conflict between inline suggestions and cmp's suggestions. I have seen similar requests passing by a couple of times on Discord as well. Additionally, a new configuration option disable_inline_completion has been introduced to allow users to disable the built-in inline completions when relying on the nvim-cmp ones. I have also updated the README accordingly.

It seemed much nicer and more integrated to have this feature in the main repo. However, with a joint effort, it can be made into a separate plugin as well.

While at it, I also added a helper function .has_suggestion() to help with alternative implementations. (#10) (#15)

Please let me know if there is anything else I need to address before accepting this pull request.

https://github.com/supermaven-inc/supermaven-nvim/assets/87830/fce213d3-0a5c-4dce-b5ae-d9db326078aa

Type of change

How Has This Been Tested?

I have tested it thoroughly on Lua and TypeScript projects, and it works as expected, providing both single and multi-line suggestions.

Configuration:

Checklist