supermaven-inc / supermaven-nvim

The official Neovim plugin for Supermaven
https://supermaven.com/
MIT License
621 stars 31 forks source link

Disable "Starting Supermaven..." message #70

Closed givensuman closed 2 months ago

givensuman commented 3 months ago

Every time I open a file I get a full-screen message saying

[supermaven-nvim] Starting Supermaven...
Press ENTER or type command to continue

I'm wondering if there is a config option to disable this? It's a bit annoying

sQVe commented 3 months ago

Just set the log_level config option to off.

praveenperera commented 3 months ago

this should be defaulted to off, its annoying and unnecessary

GabeDuarteM commented 3 months ago

I imagine if I just set log_level to off, it would remove every logging no? Thats not ideal, if something important pops up, I still want to be notified, I just want to avoid spam when I open the editor...

For now, because I'm using noice, I can just configure it to ignore this message, but I wish I didn't need to do it :sweat_smile:

if anyone else wants to also ignore it and its using noice, I configured it like this (lazy.nvim setup, if you're using something else, update it accordingly, the important part is the filter object):

  {
    "folke/noice.nvim",
    optional = true,
    opts = function(_, opts)
      vim.list_extend(opts.routes, {
        {
          filter = {
            event = "msg_show",
            any = {
              { find = "Starting Supermaven" },
              { find = "Supermaven Free Tier" },
            },
          },
          skip = true,
        },
      })
    end,
  },
torarvid commented 3 months ago

Isn't this just one of the downsides of setting cmdheight=0 in neovim? If you have cmdheight=1 (the "older default value" for cmdheight), there is no "Press Enter to continue" message.

GabeDuarteM commented 3 months ago

At least for me, the problem is not the Press Enter to continue message, since I use noice.nvim I get a popup notification that disappears after some seconds requiring no interaction. The problem for me is the message itself which is spammy and unnecessary IMO, since I installed the plugin and already expect it to start automatically (since that's how I configured it :sweat_smile:).

I'd expect such messages and would find it okay to be displayed if there was any kind of failure, but since I already expect it to succeed to start, thats not something I think I should be reminded of (at least not by default, as it is currently)...

AlejandroSuero commented 3 months ago

@givensuman I created a PR fixing this behaviour.

When I introduced the feature, initially it was supposed to have silence_info = true so that "info" messages like `Starting Supermaven ..." and such could be avoided, but it was scratched.

What I did in the PR is that if you set log_level to anything other than warn or error it will print all, except if its set to off obviously. But if you just want "relevant" information, like warns and errors, just simply set it to one of them.