Closed mrxz closed 1 year ago
Can you please update the index.html to use
<script src="https://aframe.io/releases/1.4.2/aframe.min.js"></script>
Thanks
Can you please update the index.html to use
<script src="https://aframe.io/releases/1.4.2/aframe.min.js"></script>
Thanks
Done :-)
Thank you both!
This PR replaces the
luminance
uniform in the sky shader for anexposureBias
uniform. This avoids a name collision with theluminance
method in newer version of Three.js (part ofcommon.glsl
shader chunk).Functionally it serves the same purpose, where
exposureBias
is easier to use for artistic purposes as it linearly adjusts the exposure. This means that lower values result in less exposure, and higher values in higher exposure. This in contrast with the previousluminance
which was only valid for values between 0.0 and ~1.2, wasn't linear and resulted in less exposure for higher values.The output is identical as before (with the default value of 1.0), so this PR doesn't change the default appearance of the skyshader. Note that the tone mapping logic isn't quite correct, so terms like "luminance" or "exposure" are as a result also not quite accurate for what they do.
Fixes #87