supermedium / aframe-react

:atom: Build virtual reality experiences with A-Frame and React.
https://ngokevin.github.io/aframe-react-boilerplate/
MIT License
1.42k stars 151 forks source link

Passing non-strings to setAttribute #101

Open trusktr opened 7 years ago

trusktr commented 7 years ago

This is a good idea!

I mean, for someone writing a lib like A-Frame, this is something that will surely cross the mind and possible optimization.

It's something I have planned to do in my lib, infamous. (Without having known someone else like you had already done it, until just now).

I opened this issue on React a while back, not knowing anyone else actually tried it:

https://github.com/facebook/react/issues/10070

It'd be great to have your input on that.

If they can simply fix a one-liner, the I don't have to make something like infamous-react, for example, and not having to make infamous-react means easier maintenance.