Pass empty props to aframe as ""

supermedium / aframe-react

:atom: Build virtual reality experiences with A-Frame and React.

https://ngokevin.github.io/aframe-react-boilerplate/

MIT License

1.42k stars 151 forks source link

Pass empty props to aframe as "" #23

Closed shea-hawkins-zz closed 8 years ago

shea-hawkins-zz commented 8 years ago

Skipped stringifying false values, letting aframe handle that coercion. Also filters out garbage props before outputting aframe element.

shea-hawkins-zz commented 8 years ago

Shoot, yes it should be. Thanks for catching that!

shea-hawkins-zz commented 8 years ago

Okay, I've fixed these -- please let me know if you see anything else.

ngokevin commented 8 years ago

Thanks, will take a look when i can

shea-hawkins-zz commented 8 years ago

Yep you're right, I have removed the hasOwnProperty check.

ngokevin commented 8 years ago

Needs a rebase

shea-hawkins-zz commented 8 years ago

Okay, the fork has been rebased.

jesstelford commented 8 years ago

@ngokevin This PR has broken the demo code in aframe-react-boilerplate (the cursor doesn't show, and the box disappears as soon as it starts rotating). Going back to ef1ecc7 works again.