search

supermedium / aframe-watcher

👀 Companion server for A-Frame Inspector to sync changes back to HTML files.
https://supermedium.com/aframe-watcher/
MIT License
96 stars 23 forks source link

CTRL-C will now exit the program #16

Open Luk164 opened 3 years ago

Luk164 commented 3 years ago

Just a simple piece of code added to the end of the file + two booleans to check if files are being written to. Also does not allow files to be written while shutting down and will automatically reject incoming connections. Relates to issue https://github.com/supermedium/aframe-watcher/issues/13

Juankz commented 3 years ago

I tested this PR but it isn't working for me. If don't save any changes it shutdows with Ctrl-C. But after I have saved any change in the scene Ctrl-C no longer works

Juankz commented 3 years ago

Update: Seems to be a problem with the package prompt-confirm capturing the input and not reporting the SIGINT signal. See https://github.com/enquirer/prompt-confirm/issues/9

Luk164 commented 3 years ago

@Juankz That repo seems to be dead, I dont really know how to proceed here

Juankz commented 3 years ago

I talked on discord with one of the maintainers, the repo is not dead but is not much active either. If you could help testing my PR it would make it easier to merge.

Luk164 commented 3 years ago

I talked on discord with one of the maintainers, the repo is not dead but is not much active either. If you could help testing my PR it would make it easier to merge.

I do not see any PRs from your account there, could you drop a link?

Juankz commented 3 years ago

Sure https://github.com/supermedium/aframe-watcher/pull/20