supermedium / moonrider

🌕🏄🏿 Surf the musical road among the stars. Side project built by two people in a few months to demonstrate WebXR.
https://moonrider.xyz
MIT License
569 stars 218 forks source link

Some beatmaps throw exception causing game to go weird state #182

Closed kenshin171 closed 4 months ago

kenshin171 commented 6 months ago

Some of the newer beatmaps will throw an exception below. After which the same will be in a weird state where the loading beatmap screen will be stuck there

build.js?v=3:16 Uncaught TypeError: Cannot read properties of undefined (reading 'sort')
    at i.processBeats (build.js?v=3:16:8332)
    at i.update (build.js?v=3:16:8071)
    at i.callUpdateHandler (component.js:419:10)
    at i.updateProperties (component.js:300:12)
    at HTMLElement.value (a-entity.js:490:19)
    at HTMLElement.value (a-scene.js:722:43)
    at HTMLElement.<anonymous> (a-entity.js:727:14)
    at HTMLElement.value (a-scene.js:553:40)
    at i.onStateUpdate (build.js?v=3:343:55320)
    at AFRAME.registerSystem.dispatch (build.js?v=3:343:52193)
moocow1452 commented 5 months ago

Seen this with the Pizza Tower OST. Thought it had something to do with the artist being "Mr. Sauceman" and the "." was throwing something for a loop.

unsupervisednn commented 4 months ago

I opened a PR to show a user error message instead of crashing.

You can see my version at https://unsupervisednn.github.io/moonrider

kenshin171 commented 4 months ago

ah so its a beatmap version incompatability issue. Sad, moonrider not supporting version3 beatmaps is quite a waste. Moonrider is one of the better rythm slashing games out there even compared to native games like multrix or beatLabs.

kenshin171 commented 4 months ago

I opened a PR to show a user error message instead of crashing.

You can see my version at https://unsupervisednn.github.io/moonrider

somehow when i try, the sound when i slash the notes seems either lag or sppear at all. seems different from the original moonrider.xyz.

frabul commented 4 months ago

This pull request should solve the problem https://github.com/supermedium/moonrider/pull/200

moocow1452 commented 4 months ago

It looks like the latest version on the website solves this issue.

kenshin171 commented 4 months ago

yes seems like its fixed as mention below, i will jus close this issue then

This pull request should solve the problem #200