search

supermedium / moonrider

🌕🏄🏿 Surf the musical road among the stars. Side project built by two people in a few months to demonstrate WebXR.
https://moonrider.xyz
MIT License
569 stars 218 forks source link

Show error message for incompatible beatmap version instead of crashing #185

Closed unsupervisednn closed 4 months ago

unsupervisednn commented 4 months ago

Some of the beatmaps are version 3 with different object keys and added features. This PR shows an error message when these songs are selected instead of crashing. I didn't see a way to grab/filter compatible versions only. Sometimes the beatmap versions were different from the info object, so I scanned for the version in beatmap instead.

dmarcos commented 4 months ago

No need to commit the package-lock.json

dmarcos commented 4 months ago

Cool. Thanks. I'm gonna hold on merging this to see if we can fix https://github.com/supermedium/moonrider/issues/186 first quickly. If not we might need to revert to an A-Frame 1.1.0 commit and want to keep history simple.

dmarcos commented 4 months ago

This needs rebase

dmarcos commented 4 months ago

This needs rebase