supermedium / moonrider

🌕🏄🏿 Surf the musical road among the stars. Side project built by two people in a few months to demonstrate WebXR.
https://moonrider.xyz
MIT License
581 stars 225 forks source link

Opening keyboard freezes page. It doesn't work #186

Open dmarcos opened 7 months ago

dmarcos commented 7 months ago

I merged this https://github.com/supermedium/moonrider/pull/175 to bump to A-Frame 1.3.0 and I've got reports that keyboard no longer works (Quest 2 and 3). @redsolver anything quick comes to mind? Thanks so much

dmarcos commented 7 months ago

More info from users:

-The crash occurs when you simply hover over the keyboard, most times you do not need to interact with the actual keys, it is the keyboard field. -Menu Resolution appears to be lower, within maps might be similar as well -The end of the first map you play after loading/reloading the website loops the intro for about 1.5-2 seconds, then goes to stats screen -Stats screen does not show "Rank" you receive on stats screen (S, A, B, C)

unsupervisednn commented 7 months ago

Yea I had based my PR on that one and found out the super-keyboard expects different UV mapping API in Three.js

dmarcos commented 7 months ago

@unsupervisednn thanks .if you have some code to quickly fix the keyboard I'll deploy it. Otherwise will have to revert the A-Frame 1.3.0

unsupervisednn commented 7 months ago

It was crashing a bit more while playing on a-frame 1.3.0. I dont personally use this with Windows Chrome so didn't feel it was worth lots of QA and debugging to update a-frame when the older version worked fine on quest browser, sorry

frabul commented 7 months ago

I tried it a few hours ago and the bug was gone....

digama0 commented 7 months ago

The issue with the rank ('S', 'A', 'B', ...) text not showing up still exists, and the console shows issues with FontLoader and TextGeometry having moved out of three.js (they are only stubs now, so naturally it would not render). I tried fixing it by using

import { FontLoader } from "super-three/examples/jsm/loaders/FontLoader";
import { TextGeometry } from "super-three/examples/jsm/geometries/TextGeometry";

and adding "super-three": "^0.137.0" to the packages.json, but this seems to yeet the camera to NaN on first render, so I'll see if someone who knows the system better can propose a better fix.

frabul commented 7 months ago

Why the three version that is included in AFRAME does not include FontLoader and TextGeometry examples?

frabul commented 7 months ago

The way i did is

It seems to work without any side effect