Fix keyboard crashing - Githubissues

supermedium / moonrider

🌕🏄🏿 Surf the musical road among the stars. Side project built by two people in a few months to demonstrate WebXR.

https://moonrider.xyz

MIT License

569 stars 218 forks source link

Closed Maxmystere closed 4 months ago

Maxmystere commented 4 months ago

Here is the fix for #186

dmarcos commented 4 months ago

Wow. thanks so much! Did you try also updating to A-Frame 1.5.0?

Maxmystere commented 4 months ago

I'll try to take a look at it if I have some time but I sadly still lack proper knowledge about JS and A-frame to properly fix some issues

dmarcos commented 4 months ago

@Maxmystere Thanks. There's one more little regression from the update reported:

Just in case you have a quick fix in mind.

Maxmystere commented 4 months ago

From the tests I didn't think it was an artifact, I'll check it