search

supermedium / moonrider

🌕🏄🏿 Surf the musical road among the stars. Side project built by two people in a few months to demonstrate WebXR.
https://moonrider.xyz
MIT License
581 stars 225 forks source link

Update moonrider to aframe 1.0.4 #97

Closed cabanier closed 4 years ago

cabanier commented 4 years ago

moonrider is broken in browser that have deprecated WebVR because it uses a deprecated WebXR interface. This change upgrades the version of aframe which uses the current WebXR interface.

dmarcos commented 4 years ago

Thanks for doing this. It's super appreciated 🥇

cabanier commented 4 years ago

@dmarcos do I need to do anything else for this PR to land?

ngokevin commented 4 years ago

Thanks, did you happen to test the game on any devices?

cabanier commented 4 years ago

I only tried it on Quest

dmarcos commented 4 years ago

@cabanier Thanks. Did you try over https so the WebXR code path is issued? A-Frame 1.0.4 defaults to WebVR over http on the Oculus Browser.

cabanier commented 4 years ago

I don't have a https server unfortunately. I changed my browser flags so my site was marked as secure (#unsafely-treat-insecure-origin-as-secure in chrome://flags) and also disabled WebVR. This meant that the WebXR path was taken in the aframe code. I was able to play a level and everything looked the same as before.

cabanier commented 4 years ago

@dmarcos so I think this will work. Is there a way for you to try it?

ngokevin commented 4 years ago

thanks, will test later to deploy

dmarcos commented 4 years ago

@cabanier Thanks for the effort! 👍