search

supermedium / superframe

:package: A super collection of A-Frame components.
https://supermedium.com/superframe/
MIT License
1.38k stars 424 forks source link

a-sun-sky not working with aframe 0.8 #147

Open homerjam opened 6 years ago

homerjam commented 6 years ago

Hi Kevin

I've looked at the aframe docs and can't figure out what's changed to cause the sun-sky component to break. If you have a chance to look into it that'd be great.

Here's an example

Thanks! James

Dante83 commented 6 years ago

Hi homerjam,

I just noticed this while rummaging through code. My own code-base hits a similar problem, so I thought I'd share the solution. There's a small glitch with 0.8.0 that requires you to add side: back into the materials attribute for a-sun-sky, so that you code looks as follows,

<a-sun-sky material="sunPosition: -0.2 0.5 -5; side: back" geometry="" scale=""></a-sun-sky>

You can see this in action here: https://jsfiddle.net/owqz4mky/4/

This is A-Frame version dependent and a known issue, so I imagine this should be solved in future versions (in which case you might have to change this back if the sky goes blank again).

Sincerely, Dante

homerjam commented 6 years ago

Thanks @Dante83 !