search

supermedium / superframe

:package: A super collection of A-Frame components.
https://supermedium.com/superframe/
MIT License
1.38k stars 424 forks source link

geometry-merger, no working demo, example code doesn't work #298

Closed kylebakerio closed 1 year ago

kylebakerio commented 3 years ago

When example from readme is copied, just console errors. See: https://glitch.com/edit/#!/heady-comfortable-dinner

kylebakerio commented 3 years ago

The demo featured within the repo has more code. Grabbing that, and updating it to use aframe 1.0.4 or 1.1.0 seems to mostly work, though it breaks entirely in 1.2.0. Even in 1.0.4 and 1.1.0, you get errors in the console every time you grab the scene, or look at the merged components, however--not sure what to make of those at a quick look right now.

https://glitch.com/edit/#!/flicker-spring-kite?path=index.html%3A7%3A49

Seems 0.9.0 (as featured in readme) and 0.7.something (as featured in repo) do not work.

vincentfretin commented 1 year ago

321 was merged and is included in a new release https://www.npmjs.com/package/aframe-geometry-merger-component so I guess we can close this issue?