supermerill / SuperSlicer

G-code generator for 3D printers (Prusa, Voron, Creality, etc.)
4.12k stars 519 forks source link

Enable CWS Output for SLA Printers #2844

Open aelnagger opened 2 years ago

aelnagger commented 2 years ago

Is your feature request related to a problem? Please describe. I want to be able to setup slicing and exporting for my Monoprice mini SLA printer, which typically uses the Malyan S100 moniker.

Describe the solution you'd like Add options for Malyan or Monoprice printers to the configuration assistant. Make the necessary changes required to plumb an SLAArchive depending on the current requested format.

Describe how it would work I'm not familiar with making changes to supported printer configurations.

As far as plumbing the correct SLAArchive implementation, I believe the BackgroundSlicingProcess implementation needs to utilize the Slic3r::get_output_format function to get the correct output formatter when beginning the export step. It looks like the CLI might already have support for exporting CWS.

Describe alternatives you've considered Fair amount of investigation performed, but no real alternatives seriously considered. It's worth noting that the existing Prusa SL1 profile exposes a setting to allow for CWS output.

Screen Shot 2022-05-28 at 3 55 45 PM

Manual testing seems to indicate that even though the option is set, the exported SL1 archive is in fact generated using the SL1Archive class instead of the MaskedCWSArchive class.

Additional context

aelnagger commented 2 years ago

For what it's worth, I feel fairly comfortable making an attempt at the BackgroundSlicingProcess changes and testing them. If there's guidance that I've missed on adding new profiles, I'd be more than happy to also trying to pull together a PR for that as well.