supermerill / SuperSlicer

G-code generator for 3D printers (Prusa, Voron, Creality, etc.)
4.04k stars 514 forks source link

Seem notch doesn't work #4143

Closed Fuechsl closed 1 month ago

Fuechsl commented 4 months ago

What happened?

I have applied 0.6mm of seem notch to a huge semi sphere, but I don't see any effect. SS 2.5.59.8 on MacOS.

grafik grafik

Project file & How to reproduce

Prj Halbkugel 2024.3mf.zip

Version

2.5.59.8

Operating system

MacOS 14.3.1

Printer model

Voron V2.4

supermerill commented 4 months ago

to check for "roundness", it looked after the polygon, to see if all angle are less than 180°. In this case, there is ~15 angles (over 300) that are between 180° and 182.2°, so that's why it fails the test.

Sometimes, that can happen with rounding errors for triangles that should be in the same plane but aren't. There is already some cleaning procedure that check for taht, and try to remove unneeded points are almost on the same "plane". Seems like yours are too far away for it to trigger.

I can modify the threshold to allow very shallow concavity.

supermerill commented 4 months ago

Also, you reduced the max angle to 90, so it can't do anything. I'll set its min value to 180, as below 180, it filters out everything.

Or maybe it's better to reverse and making it a min angle (so between 0 and 180° instead of 360 and 180) ?

Fuechsl commented 4 months ago

Yes, I thought, maybe it's because of the angles close to 180°, that's why I tried to force it by using 90° threshold. I also tried the option "for everything" (because I thought SS may not recognize my perimeter as "round" because it's larger), but this didn't work either. I've tried to print big round things before and had a lot of these ugly zits, so I thought, maybe this new option could be a way to reduce that. For me it doesn't matter if it's an outer oder inner angle as long as it works as expected. ;) Thanks for all your work btw.! Is there a way to contact you directly if I have questions or comments that better don't go in here? Discord?

supermerill commented 4 months ago

with the current, release, if you set "for everything" and put 360 in the angle, you should see it. Or wait the next nightly.

Yes, discord.