search

supermerill / SuperSlicer

G-code generator for 3D printers (Prusa, Voron, Creality, etc.)
4.11k stars 520 forks source link

Correct release page link on notification #4162

Closed arifaydogmus closed 7 months ago

arifaydogmus commented 7 months ago

Missed question mark is causing to redirect user to 404 GH page.

supermerill commented 7 months ago

in current beta (master_dev branch), the code is 

void GUI_App::open_web_page_localized(const std::string &http_address)
{
    wxString lng_param = wxString("lng=") + this->current_language_code_safe();

    // Check if http_address already contains a query parameter
    size_t query_pos = http_address.find('?');
    open_browser_with_warning_dialog(wxString(http_address) + wxString(query_pos == std::string::npos ? "?" : "&") + lng_param,
                                     nullptr, false);
}
arifaydogmus commented 7 months ago

Ohh nice then no need this PR. :) Thanks 🙏