search

supermerill / SuperSlicer

G-code generator for 3D printers (Prusa, Voron, Creality, etc.)
4.11k stars 520 forks source link

Automatic builds for apple silicon fix #4165

Open glsorre opened 7 months ago

glsorre commented 7 months ago

This small patch solves the problem with iconv not recognised during boost::locale build on apple silicon.

Furthermore it fixes the build on macOS Sonoma with latest Xcode.

supermerill commented 7 months ago

merged.

glsorre commented 7 months ago

@supermerill great! your project is super.

supermerill commented 7 months ago

I run a build, and the arm version still don't compile. logs: https://productionresultssa2.blob.core.windows.net/actions-results/24fbb031-2a06-4a4c-bc82-f19d5018dd18/workflow-job-run-ca395085-040a-526b-2ce8-bdc85f692774/logs/job/job-logs.txt?rsct=text%2Fplain&se=2024-02-29T08%3A20%3A12Z&sig=V7979Rr0JUDWeAM8QYLx80iDxz9GY3wETaE%2Fkf0UHDo%3D&sp=r&spr=https&sr=b&st=2024-02-29T08%3A10%3A07Z&sv=2021-12-02

seems like it can't find wxwidget. I wonder why... should i just try again?

glsorre commented 7 months ago

@supermerill let me give a look, also you are not in GitHub Actions?

it seems I cannot see logs, I have no rights

supermerill commented 7 months ago

I have, there is the action menu on top. I can see your builds & logs. I don't know why you can't for mine.

glsorre commented 7 months ago

I can replicate, let me investigate. It's strange as on my local machine I can build apple silicon correctly. https://drive.google.com/file/d/13fBXLvJVzxQodDBJMR6MtyiczQGQSYzn/view?usp=sharing

Leave it with me. I will solve.

glsorre commented 7 months ago

Bingo! https://github.com/glsorre/SuperSlicer/actions/runs/8095431632/job/22122105390

The problem is libTIFF shasum check. Look at deps/TIFF/TIFF.cmake

Sorry but i forgot to put this change in the PR.

glsorre commented 7 months ago

It does not build with the -b flag though. I will try to understand why.

glsorre commented 7 months ago

Bingo2! https://github.com/glsorre/SuperSlicer/actions/runs/8112691883

This solves the nlopt problem on the debug builds.

I am not a super expert of cmake so please evaluate if the change can have an impact on other platforms.