search

supermerill / SuperSlicer

G-code generator for 3D printers (Prusa, Voron, Creality, etc.)
4.13k stars 520 forks source link

Feature request: Gyroid tweak #75

Closed uniacke1 closed 5 years ago

uniacke1 commented 5 years ago

This is a future feature request to include the gyroid improvement shown here: (note: Not currently stable, I'm just marking it for the record so we can hopefully suck it in in the future and make one more featureful fork than 30 different forks each with one feature. But I understand if you don't want to deal with maintaining and importing someone else's code)

https://www.youtube.com/watch?v=SMEVg4qGzEI

Source: https://github.com/wavexx/PrusaSlicer/

wavexx commented 5 years ago

Whoa, I didn't think I would see this!

The code is obviously public for this, there are three commits currently which are based up on this code anyway (see https://github.com/prusa3d/PrusaSlicer/issues/1690 where this started).

I didn't do a PR yet as I don't think the current changes are ready. Layer thickness still needs to be taken into account. And as I rebased frequently on top of prusa's master, the commit hashes changed a few times..

uniacke1 commented 5 years ago

We're 3d printing nerds, we like our features bleeding edge, and often :D

supermerill commented 5 years ago

the commit hashes changed a few times

Oh, that's why i'm notified every day about the same commit!

I'll wait your release to merge.

wavexx commented 5 years ago

Sorry for this, but I try to limit the number of branches I have, otherwise I really have an hard time keeping up as well :/

supermerill commented 5 years ago

no worry, do as you want.

wavexx commented 5 years ago

Didn't forget! https://github.com/wavexx/PrusaSlicer/tree/gyroid_improvements or https://github.com/prusa3d/PrusaSlicer/pull/2730

I'm not going to rebase this :)