supermileage / dynamometer-pcb

Dynamometer pcb kicad project
0 stars 0 forks source link

Fix potentiometer footprint #17

Closed cosparks closed 1 year ago

cosparks commented 1 year ago

The through-holes on the right side of footprint are too far apart vertically. It seems like they should be within the bounds of, and not centred at the corners of the courtyard.

The potentiometer's mounting supports can be bent so that they fit the current design, so this is not a deal-breaker

KevinZhiyuanDing commented 1 year ago

https://github.com/supermileage/dynamometer-pcb/commit/03d35e74a3f1db1f3750efc926a0eced5b3e5ced

cosparks commented 1 year ago

@KevinZhiyuanDing I still get notifications for this repo so saw that you are working on this.

I forgot to add that the potentiometer footprint also should be rotated 90° counter-clockwise, so the knob sits in the correct position when it's zeroed. I'm not sure if knobs for d-shaft pots are standardized, but all the ones that I checked out at lee's electronics were the same.

this is zero (closed)

image

but this should be zero:

image

And to fully open the pot you rotate clockwise 270°