search

supermileage / dynamometer-pcb

Dynamometer pcb kicad project
0 stars 0 forks source link

Fix Rotary Encoder Footprint #14 #21

Closed KevinZhiyuanDing closed 10 months ago

KevinZhiyuanDing commented 10 months ago

PDB edited for non breakout board rotary encoder. Its footprint is standard to that of model EC11. 3 Pull-up resistors of 5k Ohms were used.

Before:

image image

After:

image image
cosparks commented 10 months ago

cool!

the only thing that stands out to me is spacing. this is purely aesthetic, but it looks like the rotary encoder isn't centred, and the spacing between the encoder and the two buttons isn't equal. If that's out of scope for this pr then that's totally fine.

KevinZhiyuanDing commented 10 months ago

Looks good.

  • Would you mind updating me on the specific model number of the rotary encoder once/if it is chosen?
  • For my own curiosity, was the potentiometer rotated CCW?
  • As a suggestion for future PCB changes, showing the before and after of the PCB and/or schematic in the PR is really helpful.

Other than that, looks good and wait for feedback from @cosparks.

The potentiometer is also rotated counterclockwise by 90 degrees as specified by Colby Sparks in https://github.com/supermileage/dynamometer-pcb/issues/17#issuecomment-1783923569