Cannot publish view, throws error (acorn v4?)

supermundano / sage-the-events-calendar

Add The Events Calendar support to Sage 10.

MIT License

12 stars 9 forks source link

Closed fgd007 closed 6 months ago

fgd007 commented 6 months ago

In the last publication step I get this error:

In TheEventsCalendarServiceProvider.php line 7:

Class Supermundano\Sage\TheEventsCalendar\TheEventsCalendarServiceProvider cannot extend final class Roots\Acorn\ServiceProvider

Could this have something to do with using the latest version of Acorn (version 4.2.2)?

cfaria commented 6 months ago

Hi @fgd007, thanks for your heads up!

Can you try with dev-main? If you confirm this last commit fixes the issue I'd tag a new version.

Thank you!

fgd007 commented 6 months ago

@cfaria thanks, works! I was about to submit a PR with the same solution, as described here https://roots.io/acorn/docs/upgrading-acorn/

cfaria commented 6 months ago

Cool!

Tagged 1.0.6 ;)