search

superna9999 / meta-meson

Upstream Linux Amlogic Meson Yocto/OpenEmbedded Layer
https://github.com/superna9999/meta-meson/wiki
MIT License
100 stars 67 forks source link

kernel-module-mali-utgard: Include fix for kernels 5.3 or greater #88

Closed dkruces closed 4 years ago

dkruces commented 4 years ago

Include patch to fix:

| /workdir/build/tmp/work/libretech_ac-poky-linux/kernel-module-mali-utgard/r7p0-00rel1-meson-gx-r0/git/driver/src/devicedrv/mali/linux/mali_osk_time.c:57:9: error: implicit declaration of function 'ktime_get_boot_ns'; did you mean 'ktime_get_raw_ns'? [-Werror=implicit-function-declaration] | 57 | return ktime_get_boot_ns(); | | ^~~~~ | | ktime_get_raw_ns

Signed-off-by: Daniel Gomez dagmcr@gmail.com

dkruces commented 4 years ago

I've included the patch from this pull request from last year to fix ktime_get_boot_ns error.

BTW, any reason why it wasn't merged? I can undo the changes if the pull request is accepted and merged.

Thanks

superna9999 commented 4 years ago

Oops missed the pull request... looking right now, sorry

superna9999 commented 4 years ago

I merged the PR, but I think we should only use Lima on GXBB/GXL SoCs and panfrost for GXM, but until we have panfrost for G12A/G12B/SM1, we still need the ugly driver :-/

dkruces commented 4 years ago

I merged the PR, but I think we should only use Lima on GXBB/GXL SoCs and panfrost for GXM, but until we have panfrost for G12A/G12B/SM1, we still need the ugly driver :-/

Good to know. In this case it is using mali-utgard oot driver in all the boards, isn't? Well, it's not included in any image but still is the one you should use it in all the amlogic SoC for now. Is this correct?

BTW, the PR is updated with the latest mali-utgard version. Thanks!

superna9999 commented 4 years ago

I merged the PR, but I think we should only use Lima on GXBB/GXL SoCs and panfrost for GXM, but until we have panfrost for G12A/G12B/SM1, we still need the ugly driver :-/

Good to know. In this case it is using mali-utgard oot driver in all the boards, isn't? Well, it's not included in any image but still is the one you should use it in all the amlogic SoC for now. Is this correct?

mali-utgard is only for GXBB/GXL, for GXM it needs mali-midgard and for for G12A/G12B/SM1 it needs mali-bifrost. I haven't pushed midgard/bifrost on master because I was fed up integrating the userspace libmali in yocto... so Mesa's Lima & Panfrost is muuuuuuuuuuuuuuuuuuuch simple to integrate ! (1 line in a bbappend)

BTW, the PR is updated with the latest mali-utgard version. Thanks!

Thanks for all your work, I appreciate a lot !