superna9999 / meta-meson

Upstream Linux Amlogic Meson Yocto/OpenEmbedded Layer
https://github.com/superna9999/meta-meson/wiki
MIT License
100 stars 67 forks source link

wifi-fw: Remove recipe and add brcm fw dependency #91

Closed dkruces closed 4 years ago

dkruces commented 4 years ago

Remove old wifi-fw_2016-08-18-5f5fae7239 recipe and include linux-firmware-bcm4356 dependency if wifi feature is in MACHINE_FEATURES.

Signed-off-by: Daniel Gomez dagmcr@gmail.com

dkruces commented 4 years ago

Hi!

Please, consider this in order to close this issue: https://github.com/superna9999/meta-meson/issues/82

Old recipe:

    install -d  ${D}/lib/firmware/brcm
    install ${S}/bcm_ampak/config/4356/fw_bcm4356a2_ag.bin ${D}/lib/firmware/brcm/brcmfmac4356-sdio.bin
    install ${S}/bcm_ampak/config/4356/nvram_ap6356.txt ${D}/lib/firmware/brcm/brcmfmac4356-sdio.txt
    install ${S}/bcm_ampak/config/4354/nvram_ap6354.txt ${D}/lib/firmware/brcm/brcmfmac4354-sdio.txt

Should we download the file brcmfmac4356-sdio.txt from here? https://github.com/LibreELEC/brcmfmac_sdio-firmware/blob/master/brcmfmac4356-sdio.txt

What about brcmfmac4354-sdio.txt, it's really necessary?

I hope this one helps so, we can get rid of the wifi-fw recipe.

superna9999 commented 4 years ago

Hi, nice, yes the -sdio.txt are necessary, so they should be pulled from somewhere, LibreELEC is a good place to pull them

dkruces commented 4 years ago

Hi, nice, yes the -sdio.txt are necessary, so they should be pulled from somewhere, LibreELEC is a good place to pull them

I've then included both firmware dependencies (4354 and 4356) in the machine configuration and I've pulled the -sdio.txt files from LibreELEC and archlinuxarm.