search

superna9999 / pyfdt

Python Flattened Device Tree Parser
Apache License 2.0
43 stars 18 forks source link

Python 3 compatibility #6

Closed zaddach closed 9 years ago

zaddach commented 9 years ago

This patch series makes pyfdt work with python2 (2.7) as well as with python 3 (3.2). On my machine, all the tests pass with python2.7 as well as python3.2.

superna9999 commented 9 years ago

Hi,

Thanks for the commit, but i'll have some questions :

zaddach commented 9 years ago

Hi,

Python 3 only allows absolute imports (or inputs with the . and .. syntax, but I did not dive to much into that). The problem with the "from pyfdt import *" is that the subpackage is also called pyfdt, which results in problems resolving the correct packet in python3, so I removed it and put absolute import paths everywhere.

I don't have a python 2.6 installation on my system, if this is important for you I can install python 2.6 and test tomorrow.

Jonas

P.s.: I saw that you're also based in Sophia. Is your company still there? I'm working for Eurecom (a research institute) at St Philippe.

On Thu, Nov 27, 2014 at 5:08 PM, Neil Armstrong notifications@github.com wrote:

Hi,

Thanks for the commit, but i'll have some questions :

  • why did you remove the "from pyfdt import " in *init.py, did the behaviour change ?
  • the python 2.6 suport is really not achievable ?

— Reply to this email directly or view it on GitHub https://github.com/superna9999/pyfdt/pull/6#issuecomment-64807894.

superna9999 commented 9 years ago

Hi,

I'll merge it in a separate python3 branch and try to fix it for python 2.6.

PS: Yes I work in sophia near St Philippe, my school was Polytech'Nice-Sophia but I finished my course before the Sophia'Tech campus was finished and Eurecom moved from CICA ...

superna9999 commented 9 years ago

Merged into my python3-compatibility branch, if you want to resumit a change, please start from this branch