rtmp audio does not pause and seek (regression)

GoogleCodeExporter commented 8 years ago

What steps will reproduce the problem?
1. go to http://flowplayer.org/plugins/streaming/rtmp.html#rtmpaudio
2. start playing
3. hit pause

What is the expected output? What do you see instead?
Expected: player pauses
Instead: continues to play

Sometimes pauses later, but pause button is not replaced by play.
Seeking also rarely works.
Basically: broken.

See also: http://flowplayer.org/forum/8/99844

Original issue reported on code.google.com by blacktrashproduct on 8 May 2012 at 8:08

GoogleCodeExporter commented 8 years ago

confirming its a problem

Original comment by electrot...@gmail.com on 9 May 2012 at 2:48

GoogleCodeExporter commented 8 years ago

OK I'll possibly have to run tests against cloudfront. There is obvious issues 
I can see already with the duration function, the duration is returning 
incorrectly which seems like server issues.

Original comment by electrot...@gmail.com on 10 May 2012 at 12:09

GoogleCodeExporter commented 8 years ago

That particular mp3 is buggered up no wonder why the durations are always all 
over the place, ill setup a ticket to replace it ;) Thats not the problem 
though, testing on cloudfront with a different mp3.

Original comment by electrot...@gmail.com on 10 May 2012 at 12:53

GoogleCodeExporter commented 8 years ago

it's not sending metadata here thats possibly the issue.

Original comment by electrot...@gmail.com on 10 May 2012 at 12:56

GoogleCodeExporter commented 8 years ago

from the looks of it i dont think it was ever working, it needs a second stream 
setup to call "id3" to obtain the metadata, im surely there is another way.

Original comment by electrot...@gmail.com on 10 May 2012 at 1:13

GoogleCodeExporter commented 8 years ago

ok ive managed to make this work without more changes to the core as the stream 
callback is solely for rtmp mp3 / id3. It's a considerable change that may 
require another release :)

http://dl.dropbox.com/u/3394987/flowplayer.rtmp-3.2.10-dev.zip

Original comment by electrot...@gmail.com on 10 May 2012 at 1:33

Changed state: Fixed

GoogleCodeExporter commented 8 years ago

huh, it's working since years in various versions < 3.2.8 on this page:
http://www.blacktrash.org/maskerade/
So, it is/was definitely some regression.

Original comment by blacktrashproduct on 10 May 2012 at 1:41

GoogleCodeExporter commented 8 years ago

Or - and that should be checked before major changes - the content-type of 
fake-empire.mp3 is not set properly in the s3 bucket! Unfortunately I have only 
rudimentary access and cannot inspect the headers.

Original comment by blacktrashproduct on 10 May 2012 at 1:46

GoogleCodeExporter commented 8 years ago

Nope - the content-type is good: audio/mpeg.

Original comment by blacktrashproduct on 10 May 2012 at 1:47

GoogleCodeExporter commented 8 years ago

dont know what im supposed to see on that page, bizarrely enough the system 
that is supposed to be in there to make it get id3 data is not, see here

http://code.google.com/p/flowplayer-plugins/source/search?q=onId3&origq=onId3&bt
nG=Search+Trunk

It's in there now though, just committed.

Original comment by electrot...@gmail.com on 10 May 2012 at 5:52

GoogleCodeExporter commented 8 years ago

ah, the young generation - you're not supposed to see, you're supposed to hear 
;-) ... on the right, beneath the picture, the black box with 2 angle brackets, 
or one of the links below - 3.2.7 with an rmtp mp3 playlist.

Original comment by blacktrashproduct on 11 May 2012 at 12:20

GoogleCodeExporter commented 8 years ago

Just tried the fix . 
http://dl.dropbox.com/u/3394987/flowplayer.rtmp-3.2.10-dev.zip.
Pause is not working before scrub. Its working well after scrub

Original comment by thehellm...@gmail.com on 13 May 2012 at 3:43

GoogleCodeExporter commented 8 years ago

This is still broken, can be tested on the stage release:
http://stage.flowplayer.org/plugins/streaming/rtmp.html#audio
For me it resuming does not work after seeking and pause.

Reopening.

Original comment by blacktrashproduct on 14 May 2012 at 12:36

Changed state: Accepted

GoogleCodeExporter commented 8 years ago

Note that this is not related to id3 tagging - there is no id3 duration tag.

Original comment by blacktrashproduct on 14 May 2012 at 12:44

GoogleCodeExporter commented 8 years ago

There seems to be a problem with fake_empire.mp3, but not id3tag related.

I tested:

rtmp://dk2isqp3f.rtmphost.com/flowplayer/mp3:fake_empire
rtmp://s3b78u0kbtx79q.cloudfront.net/cfx/st/mp3:fake_empire

and the problem is there.

And that concerns also http and the audio plugin: Different durations an try 
pausing the players at
http://stage.flowplayer.org/plugins/streaming/audio.html

But the id3 tagging is NOT the problem:

$ wget http://releases.flowplayer.org/data/fake_empire.mp3
--2012-05-14 16:22:30--  http://releases.flowplayer.org/data/fake_empire.mp3
Resolving releases.flowplayer.org... 67.201.31.35
Connecting to releases.flowplayer.org|67.201.31.35|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 5111936 (4.9M) [audio/mpeg]
Saving to: `fake_empire.mp3'

100%[==================================================>] 5,111,936   1.16M/s   
in 4.5s

2012-05-14 16:22:35 (1.08 MB/s) - `fake_empire.mp3' saved [5111936/5111936]

$ id3v2 --list fake_empire.mp3
id3v1 tag info for fake_empire.mp3:
Title  : Fake Empire                     Artist: The National
Album  : Boxer                           Year: 2007, Genre: Indie (131)
Comment:                                 Track: 1
id3v2 tag info for fake_empire.mp3:
TPE1 (Lead performer(s)/Soloist(s)): The National
TIT2 (Title/songname/content description): Fake Empire
TALB (Album/Movie/Show title): Boxer
TYER (Year): 2007
TRCK (Track number/Position in set): 1
TENC (Encoded by): Exact Audio Copy   (Secure mode)
TCON (Content type): Indie (131)

However:
rtmp://stream.blacktrash.org/cfx/st/mp3:atap
works already with 3.2.10 and rtmp 3.2.9 - that is BEFORE your changes!

See: http://flowplayer.blacktrash.org/test/rtmp-audio.html

Seems a bit like a lottery as to what mp3 files work ...

Original comment by blacktrashproduct on 14 May 2012 at 3:31

GoogleCodeExporter commented 8 years ago

Please provide OS / Browser Version / Flash Player Version

Original comment by electrot...@gmail.com on 14 May 2012 at 4:00

GoogleCodeExporter commented 8 years ago

MacOS 10.5.8

Flash 11.2.202.235:
Google Chrome 18.0.1025.168

Flash 10.3.183.19
Firefox 12.0
Safari 5.0.6
Google Chrome 18.0.1025.168 (with disabled Flash 11.2)
Opera 11.62

It's actually simple: fake_empire.mp3 is certainly not over 21 minutes long - 
on the rtmp page - and I cross checked by playing 
tmp://dk2isqp3f.rtmphost.com/flowplayer/mp3:fake_empire with mplayer: 3:23.1. 
Both http players on the audio plugin page also get it wrong - until the whole 
mp3 is buffered.

You still haven't answered how id3 tags come into the equation wrt rtmp - imho 
they're only needed for audio plugin + http + metadata retrieval (artist, album 
etc.).

Original comment by blacktrashproduct on 14 May 2012 at 5:07

GoogleCodeExporter commented 8 years ago

audio over rtmp MUST be encoded at constant bitrate (CBR) - that's the problem. 
cbr fake_empire now available via cloudfront rtmp, will update demos, docs 
etc., see: https://github.com/flowplayer/site/issues/472

Closing this.

Original comment by blacktrashproduct on 15 May 2012 at 9:08

Changed state: Fixed

supernginx / flowplayer-core

rtmp audio does not pause and seek (regression) #545