search

supernginx / flowplayer-core

Automatically exported from code.google.com/p/flowplayer-core
0 stars 0 forks source link

email template expandos {1} and {2} are the same? #564

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
The viralvideos docs say about email.labels.template:

Email body text template. The tokens in this template are replaced by values 
like so: {0}: message as filled by the user, {1}: the URL of the video page, 
{2}: the URL of the video page (2nd instance)

However, {2} seems never to differ from {1}, and {1} can be reused - I tested 
that.

Is there any use for {2} tha I have overlooked?

Original issue reported on code.google.com by blacktrashproduct on 21 May 2012 at 11:23

GoogleCodeExporter commented 8 years ago 
That is correct the second replacement index is not required, adding {1} here 
will suffice its the page url. However there is some wierd unicode issue 
therefore its not producing the html correctly.

Original comment by dani...@electroteque.org on 22 May 2012 at 2:26

GoogleCodeExporter commented 8 years ago 
So the {2} expando can basically be removed from the docs, as it only causes 
confusion?
http://flowplayer.org/forum/support.html?id=100255

The entire message interface is very problematic: Carriage returns, at least on 
Mac, do not insert newlines, but the ^M control char ...

Original comment by blacktrashproduct on 22 May 2012 at 2:53

GoogleCodeExporter commented 8 years ago 
Video Link: <a href=\u0022www.test.com/test\u0022>www.test.com/test</a> this is 
the output.

Original comment by dani...@electroteque.org on 22 May 2012 at 3:13

GoogleCodeExporter commented 8 years ago 
just wasted some time. the test files are linked to the bugged javascript api 
ahhh.

Original comment by dani...@electroteque.org on 22 May 2012 at 3:51

GoogleCodeExporter commented 8 years ago 
config fixed up

http://dl.dropbox.com/u/3394987/flowplayer.viralvideos-3.2.10.zip

defaults to {0} \n\n Video Link: <a href=\"{1}\">{1}</a>

Original comment by dani...@electroteque.org on 22 May 2012 at 3:55

GoogleCodeExporter commented 8 years ago 
https://github.com/flowplayer/site/issues/520

Original comment by blacktrashproduct on 11 Jun 2012 at 1:24

GoogleCodeExporter commented 8 years ago 
https://github.com/flowplayer/site/commit/e16994959e47a80206067114453f1c01e7aabb
42

Original comment by blacktrashproduct on 11 Jun 2012 at 1:34