supernginx / flowplayer-core

Automatically exported from code.google.com/p/flowplayer-core
0 stars 0 forks source link

httpstreaming + brselec hdtogglet: isDefault mark does not trigger initial splash #577

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. httpstreaming + bitrateselect hdtoggle where one bitrate item is marked with 
isDefault: true
2. start playback

What is the expected output? What do you see instead?
Expected: splash appears at start of playback informing of configured selection
Instead: splash does not appear

With other delivery methods setting isDefault explicitly triggers the initial 
splash.

1) If this exception for httpstreaming is intentional I have to document it.
2) If unintentional, it should be fixed.

1) or 2) ?

Please use labels and text to provide additional information.

Original issue reported on code.google.com by blacktrashproduct on 27 May 2012 at 11:31

GoogleCodeExporter commented 8 years ago
Unable to replicate

 hdButton: {
                    place: 'both',
                    splash: false
                },

disables the splash it is enabled by default, and shows fine are you sure its 
not set to disabled ? 

in the docs it mentions how to configure the splash

http://flowplayer.org/plugins/streaming/brselect.html#hd-button-and-splash-scree
n

"To disable the splash completely use splash: false."

to disable it. 

Original comment by electrot...@gmail.com on 27 May 2012 at 2:56

GoogleCodeExporter commented 8 years ago
It's about the _initial_ splash when you start playback, not the splash in 
general.

What I found:

1) isDefault: true for one clip: _initial_ splash appears (isDefault bitrate 
item selected)
2) no isDefault given: _initial_ splash does not appear (1st bitrate item 
selected)
3) with httpstreaming: _initial_ splash never appears (regardless of a 
isDefault spec)

http://flowplayer.org/demos/plugins/streaming/hdtoggle-httpstreaming.html
does not show the _initial_ splash which is to be expected because isDefault is 
not specified - but if you add the isDefault for one item the _initial_ splash 
still does not appear like it does e.g. here:
http://flowplayer.org/demos/plugins/streaming/hdtoggle.html

Clearer?

Original comment by blacktrashproduct on 27 May 2012 at 4:09

GoogleCodeExporter commented 8 years ago
ok thanks , you did however specify  isDefault: true. The default should be the 
lowest bitrate . 

Original comment by electrot...@gmail.com on 29 May 2012 at 10:39

GoogleCodeExporter commented 8 years ago
http://dl.dropbox.com/u/3394987/flowplayer.bitrateselect-3.2.10.zip

was only toggling the splash if a default is set. disabled this and also not 
display the splash when the menu is set as that disables the buttons. 

Original comment by electrot...@gmail.com on 31 May 2012 at 7:17

GoogleCodeExporter commented 8 years ago
Huh? I have no idea what you did now.

It's okay that the initial splash does not appear when isDefault is not 
specified. I already had updated the docs at 
http://flowplayer.org/plugins/streaming/brselect.html#bitrate-items :

"Set the clip as default to play on startup. Defaults to the first clip in the 
bitrates array. If no item is explictly marked as default the HD/SD toggle 
splash screen will not appear at the beginning of playback."

I filed this bug because with httpstreaming the INITIAL splash does NOT appear 
even when you specify isDefault. i.e. bitrateselect behaves differently with 
httpstreaming than with any other delivery method.

Well, I guess I'll have to spend more hours on what the next behavior change is 
when it's released.

Original comment by blacktrashproduct on 1 Jun 2012 at 12:03