search

supernginx / flowplayer-core

Automatically exported from code.google.com/p/flowplayer-core
0 stars 0 forks source link

clip.image always true #581

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
As per e.g.: 
http://flowplayer.org/documentation/configuration/clips.html#properties

"default: false"

"Is the previous clip being used as a splash image for this audio clip? Only 
relevant to audio clips."

The default is actually `true' according to my experiments.

If I remember correctly this was introduced before the coverImage property of 
the audio plugin. Could still be useful for audio over rtmp, but not when it 
always returns true.

Original issue reported on code.google.com by blacktrashproduct on 1 Jun 2012 at 7:59

GoogleCodeExporter commented 8 years ago

Original comment by blacktrashproduct on 1 Jun 2012 at 8:00

GoogleCodeExporter commented 8 years ago 
its related to the displaying of the coverimage in the previous playlist item 
for audio, image is set to true by default in the clip model for some reason. 

It looks like it can be removed from the comment and may not be needed since 
there is the coverimage property, did you want to give that a try ? Its trying 
to display an image on the previous playlist item  like autobuffering for 
videos. 

https://dl.dropbox.com/u/3394987/flowplayer-3.2.11.zip

Original comment by electrot...@gmail.com on 18 Jun 2012 at 4:23

GoogleCodeExporter commented 8 years ago 
The image stays for audio playlists so a problem that needs to be corrected and 
not related to this.

Original comment by electrot...@gmail.com on 20 Jun 2012 at 2:08

GoogleCodeExporter commented 8 years ago 
a) it's still useful when you deploy audio over rtmp, where coverImage is not 
available.

b) was your last comment aimed at coverImage and playlists?

Original comment by blacktrashproduct on 20 Jun 2012 at 2:56

GoogleCodeExporter commented 8 years ago 
yes the image property is being used for images in the playlists for audio if 
not using coverImage there is a comment to say to remove that part and just use 
coverImage instead for audio which I commented out in that zip to test. I fixed 
the problem with the coverImage displaying staying in the screen.

Original comment by dani...@electroteque.org on 29 Jun 2012 at 10:23

GoogleCodeExporter commented 8 years ago 
I was going to say if this is documented, possibly take it out as its an 
internal public property I reckon.

Original comment by dani...@electroteque.org on 29 Jun 2012 at 10:29

GoogleCodeExporter commented 8 years ago 
Ok, will remove it from docs.

Original comment by blacktrashproduct on 1 Jul 2012 at 2:37