superphy / spfy

Spfy: an integrated graph database for real-time prediction of Escherichia coli phenotypes and downstream comparative analyses
https://lfz.corefacility.ca/superphy/grouch/
Apache License 2.0
4 stars 2 forks source link

address difference between faldo:Position and faldo:position #189

Closed kevinkle closed 6 years ago

kevinkle commented 7 years ago
matt_whiteside [3:13 PM] 
@kevin faldo:Position is an owl:Class for labelling object types, but faldo:position is a owl:DatatypeProperty for linking bnodes to position literals

[3:13] 
same word, different capitalizations

kevin
[3:14 PM] 
ya, this is how its defined in the ontology if im not mistaken

matt_whiteside [3:14 PM] 
i noticed the Position is used when linking to the integer literals

kevin [3:14 PM] 
in theory rdf is cap-null but this doesnt seem to pan out in practice

matt_whiteside [3:14 PM] 
in the code

[3:15] 
so blazegraph doesn't distinguish between Position and position?

kevin
[3:16 PM] 
mm I think it does

[3:16] 
it shouldnt by definition of the rdf spec

[3:16] 
though*

[3:16] 
and ya we use

[3:16] 
 ```            graph.add((bnode_start, gu('faldo:Position'),
                       Literal(gene_record['START'])))
            graph.add((bnode_end, gu('faldo:Position'),
                       Literal(gene_record['STOP'])))```

[3:16] 
which are numerical literals

matt_whiteside [3:16 PM] 
ya, thats what i was getting at

kevin
[3:16 PM] 
and
```            graph.add((bnode_start, gu('rdf:type'), gu('faldo:Position')))
            graph.add((bnode_start, gu('rdf:type'), gu('faldo:ExactPosition')))
            graph.add((bnode_end, gu('rdf:type'), gu('faldo:Position')))
            graph.add((bnode_end, gu('rdf:type'), gu('faldo:ExactPosition')))```

[3:16] 
which are classes

[3:17] 
im not sure if/how we should chnage this, would have to refer back to the faldo spec

matt_whiteside [3:18 PM] 
For:
```graph.add((bnode_start, gu('faldo:position'),
                       Literal(gene_record['START'])))```
its lower case

[3:18] 
and  
```graph.add((bnode_start, gu('rdf:type'), gu('faldo:Position')))```
uppercase

[3:20] 
also, do you need both lines:
```graph.add((bnode_start, gu('rdf:type'), gu('faldo:Position')))
            graph.add((bnode_start, gu('rdf:type'), gu('faldo:ExactPosition')))```

[3:20] 
isn't ExactPosition a subclass of Position

kevin
[3:21 PM] 
hmm

[3:21] 
i don’t know if i ever defined that relation explicityl

[3:21] 
that would work though

matt_whiteside [3:22 PM] 
its defined in FALDO

kevin
[3:22 PM] 
faldo the ontology isnt included for performance reasons

matt_whiteside [3:22 PM] 
ohh ok

new messages
[3:22] 
then maybe it is needed
kevinkle commented 6 years ago

This issue is depreciated in Matt's phylotyper revisions. Closing.