search

superruzafa / visual-scala-reference

Visual Scala Reference
https://superruzafa.github.io/visual-scala-reference
269 stars 28 forks source link

Add Japanese translation. #11

Closed exoego closed 5 years ago

exoego commented 5 years ago

image image

superruzafa commented 5 years ago

It looks like you tried to make use of the reduce.2.svg image before being created at #6. I'll trigger the build check.

superruzafa commented 5 years ago

Hey @exoego, thanks a lot for your PR. A few considerations before going ahead with it:

Please, remove the andThen/compose additional paragraphs, they are not included in the original translation and it won't be included in that way. Related functions will be in a separate section in the future. Please, mark conversations/changes as solved as I can be noticed you are done. Try to no force push PR, in a large one like this it's easy to lost changes/modifications already fixed (at least filterNot, findLast, unzip3 contains errors in 84fe4fe).

exoego commented 5 years ago

Thanks for such careful review !!

A reason why I squashed commits and force-pushed is that it is a custom in other OSS projects where non-essential commits should be squahed to keep commit history minimized and meaningful. It is also a custom that reviwers mark conversations as solved so that reviwers confirms their comments resolved actually.

I can understand different custom so I follow it in this repo.