search

superruzafa / visual-scala-reference

Visual Scala Reference
https://superruzafa.github.io/visual-scala-reference
269 stars 28 forks source link

Add keyboard controls to search. #13

Closed exoego closed 5 years ago

exoego commented 5 years ago

This PR introduces keyboad controls to the search bar.

  1. Escape to close search.
  2. Down or Tab to move down in the seached functions, and Up or Shift+Tab to move up.
  3. Enter to open the selected function.

search-keybinds

superruzafa commented 5 years ago

Thanks for this great contribution.

It seems that the focused element is deselected when you release the Shift key (when moving up with ⇥). Can you review it?

superruzafa commented 5 years ago

Also, I don't know how hard is to scroll to the focused element when the selection goes beyond the viewport. scroll-issue

exoego commented 5 years ago

Fixed the issues. search-keybinds

superruzafa commented 5 years ago

Thanks!