search

superruzafa / visual-scala-reference

Visual Scala Reference
https://superruzafa.github.io/visual-scala-reference
269 stars 28 forks source link

fix japanese #20

Closed kinshotomoya closed 4 years ago

kinshotomoya commented 4 years ago

This PR fixes the wrong Japanese context of splitAt function paragraph.

before fix

１つ目にはインデックスが i より小さいか等しい要素すべて、もう一方には残りの要素が含まれます。 means following expample.

val list = List(1, 2, 3, 4)
val index = 2
list.splitAt(index)

=> (List(1, 2, 3), List(4))

But, this is not correct behavior.

after fix

１つ目にはインデックスが i より小さい要素すべて、もう一方には残りの要素が含まれます。 means following example.

val list = List(1, 2, 3, 4)
val index = 2
list.splitAt(index)

=> (List(1, 2), List(3, 4))

Actually, element equal to the index is not included in the first List of Tuple.

exoego commented 4 years ago

less or equal in https://github.com/superruzafa/visual-scala-reference/blob/master/_en/functions/splitAt.md#splitat need fix too?

kinshotomoya commented 4 years ago

yes, I think that needs to be fixed. May I fix it?

superruzafa commented 4 years ago

Sure, go ahead and notify me back when your PR is ready to be merged.

kinshotomoya commented 4 years ago

@superruzafa I fixed that and my PR is ready to merge.