Add Buttons - Githubissues

supersaiyanmode / PyWebOSTV

Python API for controlling LG TVs (Web OS)

MIT License

271 stars 50 forks source link

Add Buttons #24

Closed alliefitter closed 5 years ago

alliefitter commented 5 years ago

Found more buttons in the WebOS projects listed here.

one
two
three
four
five
six
seven
eight
nine
zero
asterisk
cc
exit
mute
red
green
blue
volume_up
volume_down
channel_up
channel_down

coveralls commented 5 years ago

Coverage remained the same at 84.887% when pulling 4efa3fbc9edd1090142c551fcb778b85cfe456b2 on alliefitter:add-buttons into c6236e599645d14626c4d15fad56eac9f4cbacd2 on supersaiyanmode:master.

alliefitter commented 5 years ago

Thanks! I just submitted another PR, #25, which adds wake on lan to turn TVs on. And I'm currently wrapping up another one which you may or may not be interested in. It's gonna add an agents module to pywebostv which will contain some helpers for mouse and keyboard input. MouseAgent will capture mouse input on the host machine and move the mouse on the TV. KeyboardAgent will capture keyboard input. I've just finished moving my notebook code for MouseAgent into a class and am about start on a POC of KeyboardAgent. Though, I'm not sure if this should be part of your library or an implementation of it. At any rate, the MouseAgent is working better than I expected. Thanks for all your hard work on this package!

supersaiyanmode commented 5 years ago

Cool, thanks!

As for the other part of your comment about agents module that captures host's input devices and forwards inputs to TV -- I'm leaning towards keeping it out of the core pywebostv package for it sounds like a custom use of this library which might not make sense for folks that don't have those input devices. Perhaps you could can add a section titled "Common uses of this library" (or some better title; I suck at this) to the README and link in your repository? :)

alliefitter commented 5 years ago

I was thinking the same. I think I'll just link to a gist if that's ok.

EDIT: Link to a gist in the README, I mean.

alliefitter commented 5 years ago

Pushed up a commit addressing your comments. BTW, my agents turned into a CLI last night. I went ahead and pushed it up here. Let me know if you'd want to link to in an Example Implementations (or something) section.

supersaiyanmode commented 5 years ago

Please go ahead and create a new section in the README titled "3rd Party Implementations" .. Your repo looks cool! :+1: