supersaiyanmode / PyWebOSTV

Python API for controlling LG TVs (Web OS)
MIT License
271 stars 50 forks source link

Added Power On Command to SystemControl #25

Closed alliefitter closed 4 years ago

alliefitter commented 5 years ago

Borrowed wake on lan functionality from LGWebOSRemote. klattimer was running arp with Popen in order to get the TV's MAC address. I just added a dependency which is pure Python.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.3%) to 84.543% when pulling 6aa2bbdfa838e26e654a70962a788a10945235ed on alliefitter:power-on into c6236e599645d14626c4d15fad56eac9f4cbacd2 on supersaiyanmode:master.

alliefitter commented 5 years ago

@supersaiyanmode After playing around with the CLI I've been building, I've run into some issues using this feature. Namely, having this is as an instance method of a control requires that the client connect which is pretty hard to do when the TVs not on (which is also very obvious hindsight, lol.). After our discussion on #24 about the "agents," it seems pretty clear that you want this package to be an API interface/SDK and that you don't want to shove functionality into it. Correct me if I'm wrong, but if I'm not, you can go ahead an close this PR. I'm just going to add power on functionality to the CLI.

supersaiyanmode commented 5 years ago

There were several reasons why I was always a hesitant about adding WOL into this library.

But pros:

This makes it difficult for me to decide ...