search

supersaiyanmode / PyWebOSTV

Python API for controlling LG TVs (Web OS)
MIT License
271 stars 50 forks source link

Audio output selection #27

Closed rcarmo closed 3 years ago

rcarmo commented 4 years ago

Hello there,

I'm looking for a Python library that can support external output selection like https://github.com/merdok/homebridge-webos-tv/blob/master/index.js#L344 - I was wondering if this planned for (I can test/possibly contribute depending on time).

supersaiyanmode commented 4 years ago

If you mean audio output selection, then I don't think this library supports it as of now. However, it would be extremely straightforward to implement it.

If you're willing to create a PR, I'd be happy to merge it in. :) Please look at a similar class: https://github.com/supersaiyanmode/PyWebOSTV/blob/e73438c4de9817bb98d8aa300a59cdaa218771c7/pywebostv/controls.py#L398

rcarmo commented 4 years ago

Hmmm. Nice. I hadn’t noticed that part of the code.

Besides the usual time constraints testing this is going to be tricky (can’t mess around with the TV most of the time), but I appreciate the pointer and will have a look at it.

supersaiyanmode commented 3 years ago

This was recently contributed by user Felix-Pi here: https://github.com/supersaiyanmode/PyWebOSTV/pull/43