search

supersaiyanmode / PyWebOSTV

Python API for controlling LG TVs (Web OS)
MIT License
261 stars 50 forks source link

Add note about Wake On Lan #40

Closed Gustry closed 3 years ago

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 84.395% when pulling 794d2975f3f7cb3c7fa8e6b9f7297061e5bf44ec on Gustry:patch-1 into 2692f3fc0648bf3fd8a8678efaad7149be3a028a on supersaiyanmode:master.

supersaiyanmode commented 3 years ago

What do you think about wording something like this:

This library helps establish connection with the TV and control various aspects exposed over thhe WebSocket API (once it discovers the IP address). Not depending on other libraries (such as WOL) prevents client projects from having to pull in this transitive dependency (which might not be always needed). Further, waking up a sleeping TV requires us sending a magic packet outside of the WebSocket layer that this library tries to limit itself to. We would highly encourage you to perhaps use the discovered IP address, translate that to the MAC address (there are tons of libraries that do this for you) and then send the magic WOL packet to the TV (again, tons of libraries that do this).

supersaiyanmode commented 3 years ago

BTW, thank you so much, @Gustry. You are spending so much more time in responding to other PRs (I am unable to because of some personal reasons), I'll add you as a collaborator so you don't have to necessarily depend on me :)

Gustry commented 3 years ago

Thanks for the invite. I got it.

I will squash this PR if it's fine like this. I put your suggestion.